Defer API key check so --help and --tree work without a key - #12
Merged
ClayMav merged 1 commit intoApr 7, 2026
Merged
Conversation
config.Load() no longer fails when WHEROBOTS_API_KEY is unset. Instead, the check moves to Config.RequireAPIKey(), called by executor.BuildRequest() right before an actual HTTP request is made. This lets purely informational commands (--help, --tree, version, upgrade) run without a key. Fixes BUG-1870
ClayMav
marked this pull request as ready for review
April 2, 2026 16:57
ClayMav
requested review from
a team and
peterfoldes
and removed request for
a team
April 4, 2026 03:36
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
config.Load()no longer fails whenWHEROBOTS_API_KEYis unset, allowing informational commands (--help,--tree,version,upgrade) to run without a keyConfig.RequireAPIKey()method that produces the same user-friendly error with API key creation link, now called lazily byexecutor.BuildRequest()right before making an actual HTTP requestFixes BUG-1870: --help and --tree require an api key
Test plan
go test ./...)wherobots --helpwithoutWHEROBOTS_API_KEYset — should display helpwherobots --treewithoutWHEROBOTS_API_KEYset — should display command treewherobots api <command>without key — should show the API key error with creation link